search

milesburton / Arduino-Temperature-Control-Library

Arduino Temperature Library
https://www.milesburton.com/w/index.php/Dallas_Temperature_Control_Library
973 stars 487 forks source link

@milesburton Reveretd int16_t back to int8_t due to microcontroller r… #224

Closed milesburton closed 2 years ago

milesburton commented 2 years ago

…esource constraints

milesburton commented 2 years ago

@RobTillaart If time permits would you mind sanity checking this PR?

RobTillaart commented 2 years ago

OK, but it will be later this week I expect. Have several issues in progress in my own libraries already.

milesburton commented 2 years ago

No problem Rob. Whenever you get time, appreciate you're a busy man.

On Tue, 5 Jul 2022 at 11:02, Rob Tillaart @.***> wrote:

OK, but it will be later this week I expect. Have several issues in progress in my own libraries already.

— Reply to this email directly, view it on GitHub https://github.com/milesburton/Arduino-Temperature-Control-Library/pull/224#issuecomment-1174872454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJGHMZ5DWZ5RTRI5Y2MSTLVSQB45ANCNFSM52VEGUVA . You are receiving this because you authored the thread.Message ID: <milesburton/Arduino-Temperature-Control-Library/pull/224/c1174872454@ github.com>

RobTillaart commented 2 years ago

I see, it are only two files, they are OK.

What is missing is an update of the version number in library.properties. Should be the same as in library.json.