search

milesburton / Arduino-Temperature-Control-Library

Arduino Temperature Library
https://www.milesburton.com/w/index.php/Dallas_Temperature_Control_Library
969 stars 487 forks source link

#define CONFIGURATION conflicts with other libraries #71

Closed jamesmyatt closed 7 years ago

jamesmyatt commented 7 years ago 
#define CONFIGURATION   4

conflicts with other libraries that use the same string "CONFIGURATION" in other places. For example: in https://github.com/marvinroger/homie-esp8266/blob/develop/src/HomieBootMode.hpp, CONFIGURATION is part of an enumeration.

Leads to compiler errors such as: "error: expected identifier before numeric constant".

milesburton commented 7 years ago

Good spot. We should name space this.

jamesmyatt commented 7 years ago

Is there a good reason why the scratchpad locations need to be in the header file? Would it be better to just move them into the source file? Under what circumstances would any other module need to use the scratchpad locations?

I can do this and raise a pull request, if you like.

milesburton commented 7 years ago

Go ahead @Nzbuu