search

milesgranger / gap_statistic

Dynamically get the suggested clusters in the data for unsupervised learning.
The Unlicense
217 stars 46 forks source link

_thread #16

Closed milesgranger closed 6 years ago

milesgranger commented 6 years ago

@druogury

Thanks for forking this repo and participating in the open-source movement!

Just wanted to let you know that it's bad practice to fork a repo and 'fix' bugs without letting the original maintainer know about them.

Anyways, as @rakshita95 has informed me about the incorrect gap calculation, it has since been fixed so you can remove that "Improvement" from your fork. :+1:

druogury commented 6 years ago

Hi @milesgranger, I should have informed you first about the bug. I just forgot. Sorry for that. Happy to know that I contributed to your work 👍