search

milesj / decoda

A lightweight lexical string parser for BBCode styled markup.
MIT License
196 stars 52 forks source link

Two bugs #116

Closed vladrusu closed 7 years ago

vladrusu commented 7 years ago

Decoda EmailFilter/ClickableHook fails if after the email address you add a dot.

For example:

example@x.com. This email link will be ignored. BUG 1!

Also, the following smileys are not parsed: :( :( :((((((((((( BUG 2!

milesj commented 7 years ago

The email problem looks like a legitimate bug, while, the emoticon one is correct, as emoticons require word boundaries (they must be spaced apart).

However, I don't really have time to fix this, but open to PRs.

vladrusu commented 7 years ago

Hello ! Thank you for the answer. The ecomtioncs are already separated by a space... That's why I believe it's a bug as well. I'll try to open a PR in the next days, thanks.

vladrusu commented 7 years ago

Update: Added #124 which fixes these bugs.