search

milesj / decoda

A lightweight lexical string parser for BBCode styled markup.
MIT License
196 stars 52 forks source link

Php 7.3 compatibility #143

Closed gignonje closed 5 years ago

gignonje commented 5 years ago

I just updated code to be compatible with PHP 7.3.

Seems to be working correctly, however the PHP 7.3 test seems to hang on Travis while it's working without issue on our machines.

Please comment if you see changes to be made.

milesj commented 5 years ago

Looks good. I'll test 7.3 stuff at home later today.

gignonje commented 5 years ago

Thank you for your answer. Please tell your results 😀

milesj commented 5 years ago

Worked for me locally, thanks!

gignonje commented 5 years ago

Hi, thanks for merging this PR !

I saw that you updated version in README to 6.12.0, could you create a new Github release as well ?

Thank you

milesj commented 5 years ago

Weird, could of sworn I pushed tags. I'll push again when I get home.

gignonje commented 5 years ago

Sorry to bother you, but tags are still showing 6.11.0 as latest version. 😄

milesj commented 5 years ago

@gignonje Thanks for the reminder. I pushed the tag, let me know if it still doesn't update.

gignonje commented 5 years ago

@milesj Thank you for pushing your tag, everything's good now !