Use recommended PSR-4 autoload. PHP 5.6+

milesj / decoda

A lightweight lexical string parser for BBCode styled markup.

MIT License

196 stars 52 forks source link

Use recommended PSR-4 autoload. PHP 5.6+ #149

Closed dereuromark closed 4 years ago

dereuromark commented 4 years ago

Resolves https://github.com/milesj/decoda/issues/146

Moves non autoloadable files into their recommended structure/folders.
PHP5.6+ as last PHP5 support version before going PHP7.2+

WIP for releasing.

missing:

[ ] CS (array brackets)
[x] PHP7.4+ confirmation

but this can be follow up PRs - so this PR can already be merged IMO.

dereuromark commented 4 years ago

I would recommend removing the version file in root. It is only a source to forget to change for release - I don't think anyone needs it. So far composer now tells you easier what version you are having installed. Is that OK for you? Then I would add this to this PR.

alquerci commented 3 years ago

Hello @dereuromark ,

A short comment to share my opinion about the versioning.

I see this bump to a minor version.

Removing a PHP version support should bring a new major version as it is a backward compatibility break.

However you done a good initiative by doing this stuff.

cc @milesj

dereuromark commented 3 years ago

I disagree with that reasoning. A minor is fine to remove versions that are long eol. No bc issues, composer will just prevent from Pulling. So all fine.

alquerci commented 3 years ago

Yes, you're right.