search

milesj / decoda

A lightweight lexical string parser for BBCode styled markup.
MIT License
196 stars 52 forks source link

HTTPS-URLs #29

Closed raphaotten closed 11 years ago

raphaotten commented 12 years ago

Hi all,

what would be the best way to allow the usage of "https"-urls (e.g. https://www.youtube.com/...) ?

Kind regards Raphael

milesj commented 12 years ago

https does work, where does it not for you?

https://github.com/milesj/php-decoda/blob/master/tests/filters/UrlFilterTest.php#L30

raphaotten commented 12 years ago

Sorry, I didn't point out, that I was referring to the VIDEO-Filter! :-/

The videos are always loaded via an insecure connection (HTTP://www.youtube.com/...). If the site runs on a secured connection and uses a certificate, most browsers warn the user, if there's "insecure" data loaded as well. So it would be nice, to have the possibility of the videos being loaded via HTTPS instead of HTTP.

milesj commented 12 years ago

Ok that makes more sense. I will look into this as it may require different code/URLs between the two.

milesj commented 11 years ago

I used the protocol agnostic approach, will be available in the next tag.