search

milesj / utility

[Deprecated] A CakePHP plugin for common utility classes.
MIT License
69 stars 24 forks source link

Utility.Cacheable: Cache negative results #10

Closed Ali1 closed 11 years ago

Ali1 commented 11 years ago

Firstly, a big thank you Miles for this great plugin - it's been very handy indeed appreciate your efforts!

Re: Cacheable, there is no reason not to cache negative database result, where no results are found. Please consider the following small change.

CacheableBehaviour.php Line 250 } else if ($results) { to } else {

milesj commented 11 years ago

I can see reasonings to go both ways, perhaps I can make it a setting.

Ali1 commented 11 years ago

Reasonable. Cheers

On 16 July 2013 09:13, Miles Johnson notifications@github.com wrote:

I can see reasonings to go both ways, perhaps I can make it a setting.

— Reply to this email directly or view it on GitHubhttps://github.com/milesj/Utility/issues/10#issuecomment-21027359 .

milesj commented 11 years ago

Added storeEmpty setting.