search

milesj / utility

[Deprecated] A CakePHP plugin for common utility classes.
MIT License
69 stars 24 forks source link

FeedSource: always caching #24

Closed Ali1 closed 10 years ago

Ali1 commented 10 years ago

Just a warning about line 147:

                $urlData = Cache::read($urlCacheKey, 'feeds');

This is happening regardless of whether $query['cache'] is true or false so essentially, everything is always cached.

Not sure if that is by design.

milesj commented 10 years ago

How is it always caching? It's always reading, but nothing will ever be set.

Ali1 commented 10 years ago

That's true. My mistake I falsified the cache option after it had already run resulting in persisting cache hits.

Now its just an issue of repeated useless cache reads and the inability to turn it off (whether manually or programatically) until the duration elapses, not that this a particular issue for me.

:)

Ali1 commented 10 years ago

(sorry for earlier accidental comment and close - wrong thread)