milesj / utility

[Deprecated] A CakePHP plugin for common utility classes.
MIT License
69 stars 24 forks source link

utility requires type-converter plugin without external code change #34

Closed simonberger closed 9 years ago

simonberger commented 9 years ago

Today we updated our composer project and got two new versions from decoda and utility. I see you droped support of utility but it now requires/uses type-converter without any change of the code on our side.

Our versions updated as follows:

Removing mjohnson/utility (1.6.10)

    Installing mjohnson/utility (1.7.0)
    Downloading: 100%

    Removing mjohnson/decoda (6.5.2)
    Installing mjohnson/decoda (6.6.1) Downloading: 100%

This can be a critical issue if you do not note the problem in the development environment. maybe you can have a look at and add it to the reqiurement instead of the suggestion.

Thank you.

milesj commented 9 years ago

I am aware and that's why it was a full minor version bump, probably should of been a major, but since it didn't break utilities code itself, I didn't change it. Probably should have though.

The project is also marked as abandoned/deprecated, so proceeding with caution should be taken. I'm not sure I will change this as the utility/type-converter is only used for a very small portion of the code base. If it does however turn into a larger issue, I will change it.

simonberger commented 9 years ago

In my opinion it is a code break. Only because of a simple update a running application does not work anymore. I'll take this as a reason to protect our application from updating to bigger version steps. But this utility update would not run into this configuration change. For us this is no issue anymore - we added type-converter. But if you add a requirement we could remove the explicit add of a plugin we do not use directly.

Parts of code that aren't used that often are in my point of view in greater danger to run into real issues because it maybe be noticed after it is to late.

Just my 2 cents. In any case thanks for your answer.

milesj commented 9 years ago

I moved it into a requirement.