search

milesmcc / LibreNews-Android

An Android client for the LibreNews server
GNU General Public License v3.0
35 stars 8 forks source link

Should notifications appear? #25

Open Serkan-devel opened 6 years ago

Serkan-devel commented 6 years ago

I had the app for months installed and it did nothing. Didn't see any news and reinstalls didn't change

milesmcc commented 6 years ago

Notifications should definitely appear. Could you please give your Android version, screenshots of the app, and a debug log if possible? Thanks!

AlexMeier99 commented 6 years ago

I experienced the same problem: Version 1.4 via F-Droid. Debug Notifications enabled.

After getting "Flashes Found: 22" i got "unable to load flashes from: storage/data/data/app.librenews.io.librenews/files/flashes.json: open failed ENONET" Maybe there's a typo error in the file path string.

milesmcc commented 6 years ago

@AlexMeier99 thanks for the error report. Do you use a standard Android device, with only one internal drive?

AlexMeier99 commented 6 years ago

@milesmcc no i use a android device with a internal and a additional external card.

AlexMeier99 commented 6 years ago

@milesmcc Maybe we could solve this by simply adding a path configuration input in the LibreNews Settings Activity? So it would be possible to anybody to select his or her directory for the LibreNews data.

milesmcc commented 6 years ago

@AlexMeier99 this is the line in question: https://github.com/milesmcc/LibreNews-Android/blob/974b9592fa6c4ef591f5efccc4e85468c3650684/LibreNews-App/src/main/java/app/librenews/io/librenews/controllers/FlashManager.java#L122

This is a relatively orthodox way of handling files, as it does so using Android's protected storage. Would you suggest a different approach?

AlexMeier99 commented 6 years ago

@milesmcc i'm verry sorry to admit that java is not my usual subject. Usually i do frontend development. But apart from this i think the error might be that the path depending on the android version differs. So if the user would be able to select a directory path this bug might be covered.