search

milesmcc / LibreNews-Android

An Android client for the LibreNews server
GNU General Public License v3.0
35 stars 8 forks source link

add german translation #6

Closed mueller-ma closed 7 years ago

mueller-ma commented 7 years ago

Three notes: Make the url non translatable? Do I have to translate {rate}? You use "refresh rate" and "sync disabled". Isn't both a sync, so shouldn't be only one term used?

milesmcc commented 7 years ago

Thanks for translating!

In regard to {rate}, this should not be translated. This is a placeholder, and is not user-visible. It's important that {rate} remains unchanged.

Making the URL non-translatable is an option, but I purposefully leave it available as it's possible that in the future, I will offer different distinct server URLs for different locales (perhaps separate German, Japanese, and French streams, for example). Thanks for pointing this out though.

As for the last note, I agree that it's a bit of a naming inconsistency. For all intents and purposes, they can be used interchangeably, though going forward I will use the term sync.