search

milesmcc / shynet

Modern, privacy-friendly, and detailed web analytics that works without cookies or JS.
Apache License 2.0
2.9k stars 185 forks source link

Problem with favicons #213

Closed haaavk closed 1 year ago

haaavk commented 2 years ago

DuckDuckGo favicon fetcher doesn't work with my websites. It mostly displays generic icon. For my projects on gitlab pages it displays favicon from root domain (login.gitlab.io) instead project page (login.gitlab.io/project). I think an optional field in service model to hardcode favicon url may be a good idea. I believe it's even possible to automatically get favicon url from website url with javascript. I can create PR with this.

haaavk commented 1 year ago

Closed due to lack of activity.

milesmcc commented 1 year ago

Thanks @haaavk. Ultimately I think this sort of thing is out of scope for the project.