Closed sumit4613 closed 11 months ago
Nice work with 100% code coverage. Usually it's not a best idea to mix refactoring with other changes in one commit. Adding pure subjective code style changes may not be worth it. Some of them are likely to be undone next time I'll work on API.
Hey, @haaavk understood, I'll move tests and refactoring to separate commits.
Hey, @haaavk I have separated my changes into different commits. Please review.
Also, I'm hoping you guys don't have any issues using black
for code formatting.
Black is cool. I personally prefer to keep lines length under 100. @milesmcc Are there any official code style rules for Shynet?
Black is cool
✅ 🙌🏽
I personally prefer to keep lines length under 100.
I see, I keep them around 120.
Are there any official code style rules for Shynet?
It'll be great if we can have official code style rules or a .editorconfig
file.
Yeah @haaavk Black is what I prefer. We should codify this.
@milesmcc Got any spare time to review this as well? 🤔
167
100% coverage for![image](https://user-images.githubusercontent.com/42776881/192195334-560b480a-dd92-4977-b646-d3ca22c88db2.png)
api
app.