Invalid Expression in Line 31

mileszs / ack.vim

Vim plugin for the Perl module / CLI script 'ack'

Other

3.08k stars 396 forks source link

Invalid Expression in Line 31 #104

Closed yths closed 10 years ago

yths commented 10 years ago

Something is wrong with this line: let s:ackprg_version = eval(matchstr(system(g:ackprg . " --version"), '[0-9.]+'))

When I start vim it tells me, that in line 31 (the one above) is an invalid expression.

bitboxer commented 10 years ago

I have the same error on my system

dfreedm commented 10 years ago

I'm still seeing this issue even after 08a3494

bitboxer commented 10 years ago

It's fixed for me.

kassio commented 10 years ago

@azakus which version of ack and vim are you using? and did you change your g:ackprg?

dfreedm commented 10 years ago

ack 2.12, vim 7.4 patches 1-135

I have not set g:ackprg

kassio commented 10 years ago

@azakus sorry didn't ask it in first time, but which OS are you using and how is set your wildignore?

dfreedm commented 10 years ago

OS: Arch x86_64 wildignore = *.o, *~

https://github.com/azakus/davesdots/blob/master/vimrc#L37

eddiemonge commented 10 years ago

Its now line 32.

ack 2.12

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Feb 11 2014 09:12:41)
MacOS X (unix) version
Included patches: 1-52
Compiled by Homebrew

set wildignore+=*/.git/*,*/.hg/*,*/.svn/*,*/tmp/*,*.so,*.swp,*.zip

Error detected while processing /Users/eddie/.vim/bundle/ack.vim/plugin/ack.vim:
line   32:
E15: Invalid expression:

eddiemonge commented 10 years ago

Adding: let g:ack_wildignore = 0 to my .vimrc did make the error go away but I'm not sure what that does.

kassio commented 10 years ago

I'm starting to think that was not a good idea try to respect wildignore with the plugin:

It is not a simple parse the plugin has to do, and it impedes to use ag as search tool.
You can set the ignore settings on your ~/.ackrc

I'll remove this feature for now, and we can try use it in future.

related with #93.