quickfix window grows when opening results in vsplit or tab

mileszs / ack.vim

Vim plugin for the Perl module / CLI script 'ack'

Other

3.08k stars 396 forks source link

quickfix window grows when opening results in vsplit or tab #150

Closed haolian9 closed 3 years ago

haolian9 commented 9 years ago

After :Ack Controller, I get , in quickfix window use v to open a search result with vertical split window, it works well. But if the vertical window more than 2, every time use v, the quickfix window increase, like and and

haolian9 commented 9 years ago

Maybe I forget to write out my question: why quickfix window incresed when vertical split window more than 2 ?

ches commented 9 years ago

You're right, and this is annoying.

I've fixed it on the preserve-list-size branch—just for sake of a quick fix I've removed the ability to configure the v and gv list window mappings, so this is going to need a bit more work before I can merge it to master, but if you don't care about controlling exactly what those mappings do then please give it a try!

The way the mappings configuration is handled is pretty silly really, I'm going to redo that completely I think but I'll need to take some steps for backwards compatibility or do a major version bump, so it'll be a little longer before I can finish this.

ches commented 9 years ago

I'll of course leave this issue open and update it when the fix gets merged to mainline.

QMonkey commented 8 years ago

Same problem in tab window.

Nebuchadrezzar commented 7 years ago

Any chance this is going to enter master soon?

eldemcan commented 7 years ago

Looking forward for this fix as well. It is quite annoying in terms of usability. Is there any workaround for that ?

max-ch9i commented 7 years ago

It'd be nice to have the fix in master.

Integralist commented 3 years ago

👋🏻 I see a bunch of issues raised that seem to just be gathering tumbleweed, even though they appear to be issues worth fixing. I don't believe the project is unmaintained so is there anything users can do to help the maintainer get these issues resolved?

I imagine opening PRs would be one approach and contributing fixes, but I can see (just as an example) another issue https://github.com/mileszs/ack.vim/pull/142 that I have where someone actually opened a PR to fix it, but the PR has sat open for the last 7 years 😬. Maybe that happened because the maintainer expects those types of fixes to be incorporated manually by a user 🤔

Maintaining free software without getting paid for it is hard (especially when you've got a life to live), so it would be nice to get a clearer understanding of what's expected/needed from the maintainer on this project. ❤️

haolian9 commented 3 years ago

even after 7 years, I still did not learn vimscript so that i can send a PR; and seems this issue nobody cares, I am closing this issue from my side