search

mileszs / wicked_pdf

PDF generator (from HTML) plugin for Ruby on Rails
http://www.mileszs.com/wicked-pdf-plugin
MIT License
3.52k stars 640 forks source link

Fix Propshaft encoding issue #1096

Closed yenshirak closed 5 months ago

yenshirak commented 5 months ago

We get the following error after replacing Sprockets with Propshaft: ActionView::Template::Error (incompatible character encodings: ASCII-8BIT and UTF-8)

This fix resolves the issue.

Propshaft::Asset#content returns an ASCII-8BIT encoded string because it's using File::binread under the hood so the encoding needs to be set to UTF-8 if it's a JS or CSS file.

yenshirak commented 5 months ago

@mathieujobin done

mathieujobin commented 5 months ago

@unixmonkey @mileszs Can we cut a release with this fix ?

unixmonkey commented 4 months ago

This is now released in version 2.8.0 of the Wicked PDF gem. Thank you so much for your help!

Please let me know if you have any issues!