Adds olympic_data_2016.csv - Githubissues

milevy1 / koroibos

Elixir Phoenix API of 2016 Olympic athlete data

https://koroibos-elixir.herokuapp.com/api/v1/olympians

1 stars 0 forks source link

Adds olympic_data_2016.csv #19

Closed milevy1 closed 5 years ago

milevy1 commented 5 years ago

[x] Check this if the PR has been approved by the team to be a quick patch and the rest of this form will not be filled out

What functionality does this accomplish?

Adds olympic_data_2016.csv
Imported to Google Sheets to easily review and plan out schema:

Google Sheets link: https://docs.google.com/spreadsheets/d/1XOEw25PMnf2tTBme4Xwg0iw5hAmtuVVKqndMwjug6H4/edit?usp=sharing

Notable data issues:

Rows with "height" == NA
Rows with "weight" == NA
Rows with "team" == "United States-1" instead of just "United States"
"medal" can only == "NA", "Bronze", "Silver", or "Gold"

Proposed db schema: closes #13

Screen Shot 2019-07-29 at 2 40 03 PM

milevy1 commented 5 years ago

Planned data types for schema:

Attributes	Data Type	Notes
Name	string
Sex	string	enum?
Age	integer
Height	integer	or NULL
Weight	integer	or NULL
Team	string
Games	string
Sport	string
Event	string
Medal	string	enum?

milevy1 commented 5 years ago

Proposed database schema:

https://dbdiagram.io/d/5d3f59eaced98361d6dd1d07

Screen Shot 2019-07-29 at 2 40 03 PM