search

milgra / sov

An overlay that shows schemas for all workspaces to make navigation in sway easier.
GNU General Public License v3.0
325 stars 14 forks source link

Missing error checking in src/sov/config/fontconfig.c #26

Closed emixa-d closed 2 years ago

emixa-d commented 2 years ago

I noticed that in src/sov/config/fontconfig.c, 'popen' is called without checking for NULL (e.g. if fc-match was not in $PATH). For better error messages (instead of a crash because of a NULL, or maybe even silently continuing or corrupting memory on systems without memory protection), I recommend checking the return value.

milgra commented 2 years ago

Thank you very much for pointing that out, I will add a fix in the next version.

milgra commented 2 years ago

fixed in https://github.com/milgra/sov/releases/tag/0.74