search

milibopp / carboxyl

Functional Reactive Programming library for Rust
Mozilla Public License 2.0
406 stars 19 forks source link

Fix private_in_public warnings #98

Closed killercup closed 8 years ago

killercup commented 8 years ago

This fixes the "warning: private type in public interface" warnings. Rustc tells us that "this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!".

Please note that this means that the FuncSignal struct (but not its members will be public).

milibopp commented 8 years ago

My understanding is, that FuncSignal will be public inside carboxyl. As long as it does not become part of the crate's public API, I'm fine with it. Can you confirm this?

killercup commented 8 years ago

That's my understanding as well. rustdoc doesn't include FuncSignal, which confirms that it's not part of the public API.

milibopp commented 8 years ago

Cool, thanks again. Glad to see a new contributor btw!

killercup commented 8 years ago

I just started playing around with carboxyl. I'm glad I could help out a bit :)