search

milibopp / jelly

Abstraction layer for running numerical hydrodynamics software
1 stars 0 forks source link

Implemented neq for vector and corrected eq #30

Closed Moredread closed 10 years ago

milibopp commented 10 years ago

I would prefer to keep assert_equal and assert_not_equal instead of assert_true and assert_false, since they test the same thing and provide clearer error messages upon failure.

Moredread commented 10 years ago

That is only possible for half of the Tests.

On February 20, 2014 4:59:46 PM CET, Eduard Bopp notifications@github.com wrote:

I would prefer to keep assert_equal and assert_not_equal instead of assert_true and assert_false, since they test the same thing and provide clearer error messages upon failure.

Reply to this email directly or view it on GitHub: https://github.com/aepsil0n/jelly/pull/30#issuecomment-35636371

milibopp commented 10 years ago

Are you talking about the ones added/modified in this PR? I think it's possible for all of them, as far as I can see.

Moredread commented 10 years ago

You can't test e.g for a failing equal.

On February 20, 2014 5:04:07 PM CET, Eduard Bopp notifications@github.com wrote:

Are you talking about the ones added/modified in this PR? I think it's possible for all of them, as far as I can see.

Reply to this email directly or view it on GitHub: https://github.com/aepsil0n/jelly/pull/30#issuecomment-35636886

milibopp commented 10 years ago

You're right. Sorry, I didn't realize that. In that case it could be useful to keep it like that for sake of consistency…