search

milibopp / jelly

Abstraction layer for running numerical hydrodynamics software
1 stars 0 forks source link

Feature/partnum high byte #38

Closed Moredread closed 10 years ago

Moredread commented 10 years ago

If there are more than 232 particles of one species total, the higher byte of the number needs to be written to a seperate field. You still need to split the file though, as n_part is only an int, so one file still only supports 232 particles.

milibopp commented 10 years ago

These look like separate pull requests, don't they? There is a bug fix, two separable though dependent new features and then a fix to make everything work on Python 3 (which should really be amended with the previous stuff).

Just let me review this one thing at a time, please. ;)

(So I simply flag this as invalid for now, so you can split it up.)

Moredread commented 10 years ago

No, that is one set of changes.

milibopp commented 10 years ago

Meh, okay, if you insist.

milibopp commented 10 years ago

Ok, so this appears to pass the test suite and thus does not break anything along the way. But this is only regression testing. Before merging I'd like to see some tests of the correctness of the new feature.

Moredread commented 10 years ago

Finally done it