search

milimetric / passport-mediawiki-oauth

npm module for the oauth protocol on mediawiki sites
MIT License
5 stars 5 forks source link

Properly support callback parameter #4

Open nichtich opened 5 years ago

nichtich commented 5 years ago

As discussed at https://phabricator.wikimedia.org/T145828 custom callback URL parameter seem to be broken. To me it looks like oauth_callback query parameter is never sent to the MediaWiki instance. In the end we decided to use a fixed callback URL (https://github.com/gbv/login-server/issues/39).

nichtich commented 5 years ago

Maybe this helps: https://github.com/jaredhanson/passport-oauth1/pull/7

milimetric commented 5 years ago

thanks for opening and the hint. I wrote this a while back and kind of gave up on it since the underlying library was in a terrible unmaintained state. I see things have changed, so I will try to make some time to update/clean up this implementation. Feel free to send PR if you beat me to it, I'll try to at least be responsive and test/merge any fixes.