codepathreview
commented
8 years ago :+1: Good work getting all required stories done. A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- Good job on a polished UI
- Nice to see you used the SwipeRefreshLayout for easy stream refreshes
- Good job organizing your source files
- Good job using the ViewHolder pattern to improve performance of photos in
ListView. - Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.
Implemented basic app and some additional task for instagram client, please review /cc @codepathreview @codepath