miljkovicjovan / minimalist-task-tracker

Minimalist task tracker using Local Storage
https://minimalist-task-tracker.netlify.app/
4 stars 21 forks source link

#8 Logo loads as fast as it is possible now #10

Closed Sky-De closed 10 months ago

Sky-De commented 10 months ago

Fix for Issue Number: #8

Overview:

This pull request addresses issue #8 by optimizing the loading of the project logo in the header component. Here's a breakdown of the changes made:

1. What Was Done:

A ) Added Logo Asset:

Downloaded and compressed the project logo and added it directly to the assets folder within the src directory of the project.

B ) Updated Header Component:

Imported the corresponding PNG logo into the Header component and utilized the loading="eager" attribute within the image element to optimize its loading.

C ) Added loading="eager" :

2. Reasoning:

The rationale behind incorporating loading="eager" in the Header component was to further improve the performance and user experience:

Performance Enhancement: By compressing and directly adding the logo to the assets folder, we aimed to reduce the image file size for better performance.

Loading Optimization: Using loading="eager" within the image element in the Header component ensures that the logo is loaded as a priority, enhancing the initial rendering of the application by instructing the browser to load the image immediately.

3. Impact and Considerations:

Improved Loading Speed: With the inclusion of loading="eager", the logo now loads more efficiently, especially on the initial page load, providing a smoother user experience.

Browser Compatibility: While the loading attribute is widely supported in modern browsers, we've accounted for potential discrepancies in older browser versions, ensuring graceful degradation where necessary.

consideration

if you have any questions feel free to ask, otherwise let me know it works for you with merging this PR thanks skyDe

netlify[bot] commented 10 months ago

Deploy Preview for minimalist-task-tracker ready!

Name Link
Latest commit 15a4c4fd0f5b406799f8247fac3c57cb946ec192
Latest deploy log https://app.netlify.com/sites/minimalist-task-tracker/deploys/6540ca62c86a8e0008761dd6
Deploy Preview https://deploy-preview-10--minimalist-task-tracker.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.