miljodir / md-components

Design-komponenter for Miljødirektoratet (CSS og React)
https://miljodir.github.io/md-components
MIT License
3 stars 2 forks source link

RB-2548: Add max element amount to MdAutocomplete #111

Closed turiddahl closed 7 months ago

turiddahl commented 7 months ago

Describe your changes

Adds the variable amountOfElementsShown to the MdAutocomplete component. It makes it possible to set a maximum amount of elements shown in the dropdown, which is useful when you have a very long list of options.

It has a default value of null, that returns the whole list. So it does not change existing instances of this component.

Checklist before requesting a review

github-actions[bot] commented 7 months ago

Please set a versioning label of either major, minor, or patch to the pull request.

aurorascharff commented 7 months ago

Vi har allerede en property dropdownHeight. Hva tenker du om den propertien mot denne nye? Det er kanskje lettere å bruke et antall options?

turiddahl commented 7 months ago

@aurorascharff ja jeg så den, men jeg vil ikke kun minke størrelsen på dropdownen. Det er såppas store lister at scrollbaren blir veldig liten og veldig vanskelig å bruke om vi kun bruker dropdownHeight.

aurorascharff commented 7 months ago

Jeg skjønner! Flott :)