milkboy / WME-ja

9 stars 8 forks source link

Wrong instruction #67

Closed trivia211 closed 2 years ago

trivia211 commented 8 years ago

https://www.waze.com/hu/editor/?env=row&lon=19.03978&lat=47.54220&zoom=10&lo%20...%20ueFilter=0&segments=255931421

Here JAI indicates a turn left instruction (46°<). Tiles were just updated and there is actually no voice prompt on turning left from here. Tested in Waze Live Map and Waze client.

milkboy commented 8 years ago

Not actually sure what is going on here.. According to the turn algorithm flowchart in the wiki https://wiki.waze.com/wiki/How_Waze_determines_turn_/_keep_/_exit_maneuvers (which may not be 100% correct though), it should be a "turn left" instruction...

trivia211 commented 8 years ago

Probably a bug in Waze then? Would be nice if JAI was aware of these bugs too :)

milkboy commented 8 years ago

There may of course have been some minor changes in the logic, but they have to be found by manual testing, which is slow and error prone =/

trivia211 commented 8 years ago

I see. I'm happy to help if I can. I increased the angle by 1°, we'll see what happens after the next tile update.

qwaletee commented 8 years ago

We have seen many cases where Waze does not quite match our angles, but there is no published standard, and we're 99.9% correct. There's very little we can do when Waze is occasionally inconsistent. There's surely a logic too it, but not one we can discern.

On Fri, Sep 16, 2016 at 10:00 AM, trivia211 notifications@github.com wrote:

I see. I'm happy to help if I can. I increased the angle by 1°, we'll see what happens after the next tile update.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/milkboy/WME-ja/issues/67#issuecomment-247607913, or mute the thread https://github.com/notifications/unsubscribe-auth/AMar_Ganfiylm0wr7bisgyIPxzCopOzmks5qqqDvgaJpZM4J0QEQ .

trivia211 commented 8 years ago

Ok. I reported only because the script page said "Routing instruction guessing works mostly, but bug reports with permalink and description are welcome ;)". I don't really understand why the exact algorithm Waze uses is kept secret. Knowing the routing instructions is a valuable aid for map editors.

milkboy commented 8 years ago

There are probably some unknown logic if the "other" turn is very sharp and/or the connected segment is short.. Maybe.