milke / GitFinder-Issues

Bug and issue tracker for GitFinder - git client with macOS Finder integration
16 stars 1 forks source link

"Commit" window changes #106

Open AmigaAbattoir opened 2 years ago

AmigaAbattoir commented 2 years ago
  1. It would be nice if I could resize the Commit window. On large commits, it would be easier to make it bigger to see all of the files instead.

  2. And option for a tree like view for the files that would be committed.

  3. Could the "All files" option check all the items in the view. Right now, it will still show a mix of what was previously selected or not selected. Or possibly ghost the items so there is some kind of indication that the files will be added.

milke commented 2 years ago

@AmigaAbattoir,

  1. In the latest version 1.7.4 (build 117), which I've just uploaded to the server, the commit action window can be resized. However, I wanted to keep it consistent with other action windows, so you won't see standard window controls (close/minimise/resize), and it won't go into the full screen mode (it scales and layouts correctly, but it really looks weird when in that mode), but you can resize it and enlarge it to some reasonable size.

  2. I'll implement that in one of the future updates.

  3. I don't understand this one; do you want all modified files to get automatically staged and ready for commit when you select All files option?

AmigaAbattoir commented 2 years ago

@milke Thank you!

  1. Yes, this is perfect. There is no need for full screen or other window gadgets.
  2. Great to head! Thanks again.
  3. The first time I tried to commit, I checks a couple file:

    Screen-Shot-2021-11-02-at-12 50 41-PM

    and then I click on the "All files" toggle. All the items I had checked became unchecked. This caused me to think that it wasn't going to commit all the files.

    Screen-Shot-2021-11-02-at-12 50 44-PM

    I was thinking if you select "All files", it should show them all checked something more like this:

    Screen-Shot-2021-11-02-at-12 51 15-PM

    And if you uncheck one of the items, it should switch to "Selected files" to let you know that you are no longer committing all the files, just the ones you selected.

milke commented 2 years ago

@AmigaAbattoir, thanks for your suggestions. The current implementation is based on a couple of inputs I had from other users. I'll try to incorporate your suggestions too, so that everyone is happy. If that turns out impossible with current implementation, I may add another radio-box (along with Selected files and All files, which will enable you to choose which implementation you want/prefer.

I'll try to squeeze it all in the very next update.

milke commented 2 years ago

@AmigaAbattoir, your suggestion is implemented in the latest beta version 1.7.5b2 (build 120). The commit action window now has additional option Stage all files, which will stage/check/select all "dirty" files in the repository and prepare them for committing.

Screen Shot 2022-03-06 at 16 19 19

You can download the lates beta here, but you can also update your current copy using in-app updater. Just make sure to check for the Beta release channel in the update preferences, like in the picture below.

Screen Shot 2022-03-06 at 15 43 47

Let me know how it all works.

AmigaAbattoir commented 2 years ago

@milke Thanks. I just updated, and the first time I clicked on "Stage All" and then click to uncheck an item and clicked back on "Stage All" and GitFinder froze.

Screen-Shot-2022-03-07-at-9 34 45-AM

I did a Force Quit on GitFinder and others in Activity Monitor.

Screen Shot 2022-03-07 at 9 45 14 AM

Tried again on a different repo, same thing happened. Tried again, on a different repo and then the previous two and it worked find.

milke commented 2 years ago

@AmigaAbattoir, can you reproduce reliably that behaviour, when GitFinder freezes?

AmigaAbattoir commented 2 years ago

@milke I played around more and it is something that does not always happen. If I uncheck a files and switch between "All files" and "Stage all files" a few times, sometimes there will be two green checks next to the file that was unchecked and then it freezes.