search

milke / GitFinder-Issues

Bug and issue tracker for GitFinder - git client with macOS Finder integration
16 stars 1 forks source link

Missing label in git config dialog #78

Closed unikitty37 closed 3 years ago

unikitty37 commented 3 years ago

I'm assuming you didn't mean to call it XDG_CONFIG_HOME, anyway :)

image

v1.7.1 (104) macOS 10.14.6 (18G9216)

milke commented 3 years ago

Actually, it says exactly what it should. XDG Base Directory Specification defines a bunch of environment variables, one of which is $XDG_CONFIG_HOME, which is used by git. The specification describes it as:

$XDG_CONFIG_HOME defines the base directory relative to which user-specific configuration files should be stored. If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.

If you have any suggestion about what the UI should state instead, I'd like to hear it, although I think it'd only create bigger confusion.

unikitty37 commented 3 years ago

Ah, I wasn't parsing it as a shell variable. Perhaps adding the leading $ would help?

milke commented 3 years ago

Perhaps adding the leading $ would help?

Yeah, that makes sense. Will do.

milke commented 3 years ago

Just a note, regularly setting this variable in GitFinder to match the one you set already (in case it defers from the specified default) shouldn't be necessary, it should work out of the box. But GitFinder is fully sandboxed application, so if the variable doesn't have a default value ($HOME/.config), one need to specify it manually, so it can be included into GitFinder's sandbox.

milke commented 3 years ago

'$' added in new beta version 1.7.2b1 (build 105). You can download the new beta here, but you can also upgrade your current copy automatically, just select Beta release channel.

milke commented 3 years ago

This is now officially available in version 1.7.2 (build 108), so I'm closing this.