milkey-mouse / planets

A space game.
GNU General Public License v3.0
3 stars 1 forks source link

use HashSet<QueueFamily> instead of Vec<_> #11

Closed todo[bot] closed 5 years ago

todo[bot] commented 5 years ago

.filter(|&q| q.supports_graphics() would turn into a subtraction from the graphics_capable set. could this impact use of prefer()? also useful for transfer queue selection (union of graphics & comp.)


https://github.com/milkey-mouse/planets/blob/71d957a2893b87a0341a566c3ee399b2af3acb37/src/main.rs#L220-L225


This issue was generated by todo based on a // TODO: comment in 71d957a2893b87a0341a566c3ee399b2af3acb37. It's been assigned to @milkey-mouse because they committed the code.
milkey-mouse commented 5 years ago

duh:

the trait `std::hash::Hash` is not implemented for `vulkano::instance::instance::QueueFamily<'_>`
todo[bot] commented 5 years ago

This issue has been reopened because the // TODO: comment still exists in src/render/queues.rs, as of 41c1b8245f1dbcaa17665201bf995ee50559c7d4.


If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.