search

milkey-mouse / swood

Turn any sound into an instrument
https://meme.institute/swood/
MIT License
10 stars 3 forks source link

Better errors #3

Closed milkey-mouse closed 8 years ago

milkey-mouse commented 8 years ago

  1. Thanks @HippoPig21 for discovering this When opening an unsupported type of WAV file (floats, >32 bits, other weirdness) it barfs out a standard wave.Error which nobody likes. The error text could say something like

    Error: Unsupported WAV type. Try opening in Audacity and saving as a 16-bit PCM WAV. For more details see

milkey-mouse commented 8 years ago

  1. We should probably do something about the MIDI IndexError if you have a bad MIDI and you should feel bad:

    Error: Your MIDI is bad and you should feel bad. Try opening in MidiEditor and saving over the original without editing. For more details see

milkey-mouse commented 8 years ago

Check the edge case when the MIDI file length is shorter than the start/end of the longest note Probably look after MIDI parsing entirely Or just do checks to see if the current time is beyond the set end and issue a warning.

milkey-mouse commented 8 years ago

Or if you open files badly

milkey-mouse commented 8 years ago

On the file length < end last note one turns out that was never an issue, we don't trust the MIDI metadata

milkey-mouse commented 8 years ago

k