search

milktoastlab / SolanaNFTBot

A helpful bot for tracking your Solana NFT project on discord channels.
MIT License
246 stars 130 forks source link

Handle transactions without royalties #59

Open DataKnox opened 1 year ago

DataKnox commented 1 year ago

Regarding issue #58 , this was because the buyer chose not to have royalties. In the original /src/lib/marketplaces/helpers.ts file, this block exists: } else if (transfers.length === 1) { // There should be more than one transfers as all NFT contains royalties and seller revenue return null; } This is invalid because royalties are now optional and it seems most buyers choose not to pay them.

Also. yarn.lock causes the Dockerfile to fail building, and even then it still fails to build because of a type conflict. So I just tore the dockerfile down entirely.

psavva commented 1 year ago

@kryptoj Please could you review this PR?

DataKnox commented 1 year ago

Thoughts on this?