search

milktrader / Quandl.jl

Julia api to Quandl open source financial, economic and social datasets
Other
67 stars 31 forks source link

Deprecated Base.Uint8 and Base.Nothing #88

Closed cndesantana closed 8 years ago

cndesantana commented 8 years ago

Hi,

Running the example in the docs, I found out some deprecated messages:

julia> quandl("GOOG/NASDAQ_QQQ") WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Uint8 is deprecated, use UInt8 instead. WARNING: Base.Nothing is deprecated, use Void instead. WARNING: Base.Nothing is deprecated, use Void instead. WARNING: Base.Nothing is deprecated, use Void instead. WARNING: Base.Nothing is deprecated, use Void instead. in timearray at /home/cdesantana/.julia/v0.4/Quandl/src/timearray.jl:40 WARNING: Base.Nothing is deprecated, use Void instead. in timearray at /home/cdesantana/.julia/v0.4/Quandl/src/timearray.jl:40

Is it possible to eliminate these warnings? Do they have any effect in the performance of Quandl?

Thanks!

milktrader commented 8 years ago

They don't have any performance hit other than the initial printing of grievances. What version of Julia are you running?

You can checkout your own branch, make changes, commit them and then push the branch to your fork and then github will fashion a PR, which I'll be happy to merge.

milktrader commented 8 years ago

Oh, duh. You're on 0.4. Which minor release?

milktrader commented 8 years ago

I get the following deprecation warnings on 0.4.0

WARNING: Base.String is deprecated, use AbstractString instead.
  likely near /Users/Administrator/.julia/v0.4/Quandl/src/api.jl:1
WARNING: Base.String is deprecated, use AbstractString instead.
  likely near /Users/Administrator/.julia/v0.4/Quandl/src/api.jl:1
WARNING: Base.String is deprecated, use AbstractString instead.
  likely near /Users/Administrator/.julia/v0.4/Quandl/src/api.jl:1
WARNING: Base.String is deprecated, use AbstractString instead.
  likely near /Users/Administrator/.julia/v0.4/Quandl/src/api.jl:120
cndesantana commented 8 years ago

Hi,

Thanks for your response. I am running Julia Version 0.4.0-rc3 (2015-09-27 20:34 UTC) in Ubuntu 14.04.

I will do the changes in my own branch as you suggested. Let's keep in touch about it!

Best,

Charles

From: milktrader [notifications@github.com] Sent: Saturday, November 21, 2015 3:38 PM To: milktrader/Quandl.jl Cc: De Santana, Charles Subject: Re: [Quandl.jl] Deprecated Base.Uint8 and Base.Nothing (#88)

They don't have any performance hit other than the initial printing of grievances. What version of Julia are you running?

You can checkout your own branch, make changes, commit them and then push the branch to your fork and then github will fashion a PR, which I'll be happy to merge.

— Reply to this email directly or view it on GitHubhttps://github.com/milktrader/Quandl.jl/issues/88#issuecomment-158649019.

milktrader commented 8 years ago

No problem, let me know if you run into any problems with the PR. I'll end up doing this in a week or so if you don't get to it.

cndesantana commented 8 years ago

Hi,

Thanks for this!

I did the changes in my machine and I created a branch (warningfixes). So I tried to commit the changes to this new branch but I receive the following message:

cdesantana@charles:~/.julia/v0.4/Quandl$ git push origin warningsfixes Warning: Permanently added the RSA host key for IP address '192.30.252.128' to the list of known hosts. Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

Does it mean that I need to send my public key to Quandl repository? Sorry, it is the very first time I contribute to a open source project in this way :)

Thanks!

cndesantana commented 8 years ago

Hi again,

I updated my public key and sent it again to Github. So now the error message is a bit different:

cdesantana@charles:~/.julia/v0.4/Quandl$ git push origin warningsfixes Warning: Permanently added the RSA host key for IP address '192.30.252.128' to the list of known hosts. ERROR: Permission to milktrader/Quandl.jl.git denied to cndesantana. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

Thanks!

milktrader commented 8 years ago

You need to git remote add [whatever name you want not origin though] [your github fork address] and then git push --set-upstream [whatever you named it above] warningfixes

cndesantana commented 8 years ago

Many thanks!! I hope it has worked now!

Best,

Charles

From: milktrader [notifications@github.com] Sent: Sunday, November 22, 2015 2:12 PM To: milktrader/Quandl.jl Cc: De Santana, Charles Subject: Re: [Quandl.jl] Deprecated Base.Uint8 and Base.Nothing (#88)

You need to git remote add [whatever name you want not origin though] [your github fork address] and then git push --set-upstream [whatever you named it above] warningfixes

— Reply to this email directly or view it on GitHubhttps://github.com/milktrader/Quandl.jl/issues/88#issuecomment-158758852.

prcastro commented 8 years ago

I think this can be closed now