Open ksbjr opened 7 months ago
Related: riscv: dts: starfive: add Milkv Mars board device tree
(edited 2024-05-04 update link for v4 of patch series)
"Having multi files will not pass Mainline. " hm....why not? Example: bcm2711-rpi-4-b.dtb,bcm2711-pi4-cm4-io.dtb
The axp15060 power regulator is missing from u-boot upstream config and dts for visionfive2, and there's no config option for 24c02 as on the Mars CM Lite instead of 24c04 on VisionFive 2. Otherwise it's pretty similar and seems to be interchangeable for the purpose of booting. Difficult to know for sure on the Mars CM as there's no schematic available. There's a crude hack in the u-boot dts something like the sdcard restart (?) to the display driver power to avoid having to do the work of correct regulator support.
On further looking, the chip present on Mars CM Lite 4GB rev 1.01 is marked 24c04. Why then does the code have a commit to reference 24c02? What happened!?
On further looking, the chip present on Mars CM Lite 4GB rev 1.01 is marked 24c04. Why then does the code have a commit to reference 24c02? What happened!?
Answering my own question, there is a conflict between 24c04 and the RTC on Raspberry Pi Compute IO Board, so it is intentionally set as 24c02 to avoid conflict for that particular hardware configuration. If you do not have an overlapping conflict on your CM4 carrier board then it is not a problem.
Further reference: https://github.com/milkv-mars/mars-buildroot-sdk/commit/d381610c92827de01b25843786012351b3f35519
milkv-mars.dts in mainline linux sources: https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/tree/src/riscv/starfive?h=v6.10-rc2-dts
please take time to update the linux kernel to 6.6.y stable and work on updating the dtb/dtsi files to match the new format. also please join the emmc and sd dts in to 1 file as it should work as the emmc cm and sd cm need to be 1 so we have access to both on boards that support it. Having multi files will not pass Mainline . the normal mars also needs a update