search

milkwalk / XPBoost

Updated version of XPBoost
GNU General Public License v3.0
13 stars 13 forks source link

Updated to 3.5.0 and "java.sql.SQLException: The connection property 'autoReconnect'" #30

Open TomLewis opened 3 years ago

TomLewis commented 3 years ago

https://gist.github.com/TomLewis/ca99cbb0a12e9193eebe53ed24afc198

In my config, I use; database: 'Database_Name?autoReconnect=true'

This worked perfectly fine before as this caused database issues when it randomly disconnected before.

milkwalk commented 3 years ago

@TomLewis why are u using that? I've checked it and its not actually recommended to use https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-connp-props-high-availability-and-clustering.html

The use of this feature is not recommended, because it has side effects related to session state and data consistency when applications don't handle SQLExceptions properly,

XPBoost internally uses HikariCP and it renews and manages connections automatically within some period.

TomLewis commented 3 years ago

I set it years ago, I cant remember why, there was an issue with XPBoost SQL connection breaking other things, and adding that fixed it.

milkwalk commented 3 years ago

@TomLewis are u able to check if issue still persists?