search

milkypostman / powerline

emacs powerline
Other
793 stars 118 forks source link

(powerline-central-evil-theme) stopped working after update #165

Closed rubin55 closed 5 years ago

rubin55 commented 5 years ago

Been using powerline with powerline-central-evil-theme like so for the last 2ish years:

;; Enable powerline status bar. (require 'powerline) (powerline-center-evil-theme

As of today or yesterday, that stopped working: I get a blank powerline. Commenting out (powerline-center-evil-theme) makes powerline display (albeit not very prettily). Setting another theme, like (powerline-center-theme) seems to work, looking as expected.

To summarize:

With (powerline-center-evil-theme): with-powerline-center-evil-theme

With (powerline-center-theme): with-powerline-center-theme

milkypostman commented 5 years ago

I just committed a change that looks like it broke you. Will roll that back

On Mon, Feb 25, 2019 at 09:04 Rubin Simons notifications@github.com wrote:

Been using powerline with powerline-central-evil-theme like so for the last 2ish years:

;; Enable powerline status bar. (require 'powerline) (powerline-center-evil-theme)

As of today or yesterday, that stopped working: I get a blank powerline. Commenting out (powerline-center-evil-theme) makes powerline display (albeit not very prettily)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/milkypostman/powerline/issues/165, or mute the thread https://github.com/notifications/unsubscribe-auth/AACUsvnhP8Zg_o-EL50OTLB4J9-cCoabks5vQ_uQgaJpZM4bQEw1 .

milkypostman commented 5 years ago

I have reverted what I think was the offending change. Please allow a day for this to propagate to MELPA then let me know if you have more issues or any other ideas about what went wrong.

Also please post more detailed reproductions instructions.

jrosdahl commented 5 years ago

I have reverted what I think was the offending change

The culprit is #164, not #163. My bad, sorry. (I did not fully test powerline-center-evil-theme since all I got was a blank mode-line before my change, which I now realize was due to not having an evil-mode-line-tag variable set...)

The easy fix is to revert the parts of #164 that apply to powerline-center-evil-theme, but then powerline-center-evil-theme's mode-line will still look a bit peculiar when inactive. I'll see if I can make a better fix.

rubin55 commented 5 years ago

I can confirm that at least as of today, powerline-central-evil-theme works as expected :-)