search

milkypostman / powerline

emacs powerline
Other
793 stars 118 forks source link

The focus-in-hook and focus-out-hook are deprecated #180

Closed carlf closed 3 years ago

carlf commented 4 years ago

The official replacement is the after-focus-change-function used here. It is working on my local copy.

eklitzke commented 4 years ago

This will break powerline for people using older versions of Emacs, right? I wonder if we can do something like this instead https://github.com/gonewest818/dimmer.el/commit/dce4874c66c2e3a84243741dacb42103b6b90e39

carlf commented 4 years ago

I agree that's a better approach. Please see my updated PR.

carlf commented 4 years ago

@eklitzke just wanted to bump this up. Is my revised PR ok? I've been running on my branch here and have had no problems.

milkypostman commented 3 years ago

it'd be nice to have this tested but I guess we can commit. I've looked at the change and nothing seems super out of the ordinary.