search

milkytiptoe / Name-Sync

Enables names on 4chan's forced anon boards
http://milkytiptoe.github.io/Name-Sync/
Other
18 stars 5 forks source link

"Custom Name" changes name for all posts #46

Closed bstats closed 10 years ago

bstats commented 10 years ago

On Chrome 38 with Name Sync 4.8.1, clicking the + on a post and entering a name will cause every single post in the thread to display that name.

For reference, I am using 4chanX 3.20.14

bstats commented 10 years ago

Ok, upon inspection of the code it seems the issue is that the script doesn't know the ID of any post.

I looked through to find that the uID is supposed to be set on line 214 of NameSync.coffee but I added a breakpoint there in Chrome, and it is null because the info variable is null.

Thus I looked to the initialization of the info variable and found that the problem must actually lie in Post.coffee, specifically line 31: if uID = $ '.posteruid .hand', info should be if uID = $ '.posteruid', info

Because (at least on my setup) the ID doesn't necessarily have the .hand class.

Deleting .hand made this feature work correctly for me.

specialeddy commented 10 years ago

I would recommend you get ihavenoface's fork. It is as close to Mayhem's as you can get, with some optional, non obtrusive features such as no refresh rate limit, and higher quality thread thumbnails.

Mayhems version has been discontinued and will receive no updates.

milkytiptoe commented 10 years ago

What Eddy said. https://github.com/milkytiptoe/Name-Sync/wiki/Support#supported-4chan-x-forks