search

milkytiptoe / Name-Sync

Enables names on 4chan's forced anon boards
http://milkytiptoe.github.io/Name-Sync/
Other
18 stars 5 forks source link

Fix for new HTML change #6

Closed MacilPrime closed 12 years ago

MacilPrime commented 12 years ago

Moot must have tweaked the HTML recently again. Now there's two tags with the nameBlock class (and name class, etc.) in every post, one for mobile and one for desktop. The script appeared to break because it only updated the invisible mobile nameBlock. This quick fixes that so it only affects the desktop nameBlock.

(There ought to be some simple Jquery way that would act on both blocks but I don't know enough Jquery and was just submitting a quick fix.)

milkytiptoe commented 12 years ago

Already fixed.

milkytiptoe commented 12 years ago

Also

(There ought to be some simple Jquery way that would act on both blocks but I don't know enough Jquery and was just submitting a quick fix.)

As in for mobile users too? I don't think any mobile users use the script really... I suppose there could be a check to see whether the user is mobile or desktop and edit the correct block. Editing both is just going to lag things. I'll look in to it later or you can in your free time (I know you might be busy now/for a bit)