milkytoasto / DSChaosMod

Twitch integration solution for Dark Souls
GNU General Public License v3.0
3 stars 0 forks source link

[Bug] App unusable when hitting Connect with no suitable process #15

Closed milkytoasto closed 1 year ago

milkytoasto commented 1 year ago

Describe the bug When the NoProcessFound exception is raised by the ChaosHandler, the application is thrown into an unusable state and must be restarted. This may occur if the ChaosHandler tries to hook into a process with no suitable processes to hook into, or when trying to execute an operation after the application has closed / is in a state where the associated address shouldn't be written to.

For this case, we only care about accidentally connecting when no process is running.

To Reproduce Deliberately raise the exception by hitting the Connect button when no process is running, and observe.

Expected behavior Ideally, the VotingHandler should catch this before it becomes and issue, a debug message should be logged, and the GUI should be updated to be in the 'stopped' state.

Additional context May want to take into consideration that any running tasks must be closed out.