search

milkytoasto / DSChaosMod

Twitch integration solution for Dark Souls
GNU General Public License v3.0
4 stars 2 forks source link

2 memory editor #3

Closed milkytoasto closed 2 years ago

milkytoasto commented 2 years ago

Resolves #2

Some considerations on future improvements to this portion of the codebase:

  1. I would like for it to check if the game is currently loading before triggering an effect. If it is loading, then the process should wait until the loading state has ended before proceeding. ChaosHandler could likely check if the game is loading, but in that case we also would want the VotingHandler to pause -- perhaps the accepting votes state should be updated from within the event call. Or perhaps we need 3 states, one for the voting period, one for the effect period, and one for a waiting period between the two.
  2. As it stands, trigger_effect in ChaosHandler is functionally pretty pointless to have separated from effect_controller in VotingHandler -- it might be more sensible to have the aforementioned code completely moved to ChaosHandler with VotingHandler having a reference to the event in order to set it.

But these are just nice-to-haves I suppose. Not necessary for the time-being.