search

milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.72k stars 162 forks source link

Inaccurate Tremolo Effect #1

Closed tomgalvin594 closed 10 years ago

tomgalvin594 commented 10 years ago

Currently in MilkyTracker (0.90.85), when the tremolo effect is discontinued, the volume is not reset. I was unable to find what the expected behavior is in Fasttracker 2, but several other players (I unfortunately do not have access to FT2 itself) that I tried did reset the volume once the effect was discontinued. What is the correct behavior of the effect?

Additionally, there appears to be an error in the documentation for the tremolo effect. It states that "The pitch is reset when the command is discontinued." I believe this is an error, since the tremolo effect does not affect pitch.

sagamusix commented 10 years ago

You could at least have tried to reproduce the problem in FT2, that would have shown you that Milky's behaviour is correct.

tomgalvin594 commented 10 years ago

I guess that means that I have to submit a bunch of bug reports to a few other projects then. It is good to know that MilkyTracker got it right.

Anyways, that line in the documentation still does not make sense. Any idea about what it is trying to say?

sagamusix commented 10 years ago

It's a copypasta error and has been copied over from the 4xx effect. It should say something like "the volume is not reset if the command is discontinued".

Deltafire commented 10 years ago

I've fixed the explanation in the manual, what sagamusix said is correct. Thanks guys.