Deltafire
commented
5 years ago After some discussion with fellow maintainer @dwhinham we have decided not to incorporate this PR.
We made the decision during the SDL2 upgrade that we will not continue to support legacy APIs, some reasons are:
1) Time; the amount of time we have to spend on this project is currently minimal and maintaining legacy code can be time consuming. In fact, keeping MilkyTracker running on the moving target of modern systems is time consuming enough! 2) Testing; at the moment we can test current Linux, Windows & OSX platforms in a time-efficient automated way. We cannot test obsolete APIs or hardware easily. 3) Leveraging new technologies; we have decided we would like to to use modern APIs and new C++ features - supporting older platforms prohibits this.
For users of older hardware, we have retained older binaries that will work on them - and the revision history is easily accessible if one should want to develop older versions and cherry pick newer features. The AmigaPorts fork is an excellent example of this.
Thank-you for the PR and the work you've put into the AmigaPorts fork :)
This is my attempt at keeping MilkyTracker backwards compatible with legacy systems that doesn't support SDL2. I've mainly done this as I am maintaining the MilkyTracker ports for Amiga based OS'es, which of the majority doesn't support SDL-2.
I know this could be done prettier as there are so many minor differences, but here's what I've come up with.
I intend to push my changes for the Amiga platforms to upstream too, but this will be the first step towards that. And I also believe that other retro/legacy systems would benefit from this!
Thanks!
Regards Marlon Beijer