bugfix?: sample timestamp incorrect leading zero behavior

milkytracker / MilkyTracker

An FT2 compatible music tracker

http://milkytracker.github.io/

Other

1.72k stars 162 forks source link

bugfix?: sample timestamp incorrect leading zero behavior #192

Closed Xunie closed 4 years ago

Xunie commented 4 years ago

Fix for: https://github.com/milkytracker/MilkyTracker/issues/191

I have no idea if this bugfix doesn't introduce more bugs, I don't even know how to test if formatMillisFraction works. But formatMillis seems to!

I'm also not sure if replacing those sprintf with snprintf is a good idea with regards to the future of the codebase.

But hey, it works for me!

Xunie commented 4 years ago

I see that I accidentally added a wild newline in src/tracker/SectionSamples.cpp just before the malloc.

dwhinham commented 4 years ago

Looks good to me - I amended it to remove the stray newline you mentioned and cherry-picked it into master.

Thankyou!