Click and drag to move selection in pattern editor

[exelotl]

Hi! I've been working on a feature that I couldn't live without (after using Renoise for 6 years), I hope you like it!

Summary of changes:

• Click and drag a selection in the pattern editor to move the selected pattern data
  • Use the modifier key to clone instead of moving
• More intuitive behaviour for cut/paste in the effect column
  • When cutting an effect type, the parameter value is preserved
  • When pasting an effect parameter value into an empty slot, the effect type will be set to Arpeggio (previously the effect would remain as "No Effect" so the value would not be pasted)
• Improved mouse handling near the edges of the pattern (selection is clamped to boundaries instead of ignoring input)
• Added MSYS2 + MinGW support to the CMake configuration

[dwhinham]

Thanks for the PR, the new functionality looks cool!

The MSYS2/MinGW stuff is kindof irrelevant though; I'm not sure we need this when we build for Windows with its native toolchain.

I'd be inclined to squash the drag-select stuff into one commit and merge that, then maybe think about why we might want to support another toolchain.

[exelotl]

A little busy rn but I'll make the requested changes when I can!

I included the MSYS2/MinGW stuff cause I can't build without it. The changes required to get it working were relatively small. Not expecting the project to claim official support or anything, but I literally don't have space on my machine to install gigabytes of visual studio tools. 😅

Please confirm if you want me to make another PR without any superfluous stuff. I can do it but to me it seems like extra effort for the same outcome. If we don't support MSYS2/MinGW I'm gonna have to rebase or cherry pick my commits every time I want to contribute.

[Deltafire]

Side note: 6 years ago we were using MinGW for the Windows release builds, we discovered it was breaking ASIO support:

https://github.com/milkytracker/MilkyTracker/issues/4

Since then we've been building with Visual Studio.

[exelotl]

Should be good now. If you're up for merging the pattern editor commits, I'll look into making another PR for the MSYS2 support later if you're happy for that discussion to continue. Sorry for jumping the gun with that stuff.

[exelotl]

Would you like me to revert the CMake commits to make it easier to merge?

[dwhinham]

Apologies for slow response, things have been busy back in real-life work.

Thanks for making the requested amendments, everything looks good; don't worry about reverting stuff, as mentioned we'll handle it when squashing.

I think we can forget about MSYS to be honest; as @Deltafire mentioned (I completely forgot about this) it apparently has ABI problems that lead to breakage with the ASIO backend.

If you don't want to install all of Visual Studio, you can just install the standalone MSVC compiler/build tools. I haven't tested this, but it should work.

[Deltafire]

I've removed the MinGW commits, fixedup, squashed, reworded and merged into master.

Thank-you for the PR :)