milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.69k stars 162 forks source link

macOS High Sierra: Audio doesn't get routed through Soundflower #238

Open nershman opened 3 years ago

nershman commented 3 years ago

This probably isn't an issue, but I'm curious why it happens.

I'm using Soundflower (https://github.com/RogueAmoeba/Soundflower-Original), which routes audio from applications through the app and then back to system audio so one can directly record audio output.

How is MilkyTracker handling audio differently which causes audio from the application not to get routed through Soundflower?

nershman commented 3 years ago

Update: It seems that the audio output source doesn't get updated unless the application is restarted.

Deltafire commented 3 years ago

I suspect this is happening because the new output source selected is still using the same audio driver, so when this code is reached in MasterMixer.cpp:

    // Same instance, don't allocate new audio driver
        if (audioDriver == newAudioDriver)
                return result;

..the function returns without re-initialising the driver.

This should probably be considered a bug.