Closed SoniEx2 closed 3 months ago
Not a MilkyTracker user, but I decided to pick out the meaningful lines out of the dump.
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/ppui/ListBox.cpp:380:22: runtime error: load of value 34, which is not a valid value for type 'bool'
You forgot to initialize all PPListBox fields. If you want, I can submit a PR to fix it, though I'd very much prefer upgrading to C++11 so you can put most field initializers in the .h instead of the constructor.
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/tracker/PatternEditorControlEventListener.cpp:461:8: runtime error: load of value 94, which is not a valid value for type 'bool'
You forgot to initialize all PatternEditorControl fields.
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/ppui/DialogFileSelector.cpp:270:84: runtime error: load of misaligned address 0x7ffc9dec9be4 for type 'struct PPString *', which requires 8 byte alignment
0x7ffc9dec9be4: note: pointer points here
26 00 00 00 f0 2d e7 46 22 56 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/tracker/DialogWithValues.cpp:273:84: runtime error: load of misaligned address 0x7ffc9decb3e4 for type 'struct PPString *', which requires 8 byte alignment
0x7ffc9decb3e4: note: pointer points here
26 00 00 00 c0 c0 ee 46 22 56 00 00 00 00 00 00 70 f0 6f 46 22 56 00 00 00 5d d6 0f d1 b3 81 58
^
No clue how this happened.
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/tracker/Undo.h:83:11: runtime error: null pointer passed as argument 2, which is declared to never be null
Apparently you fed a null pointer into memcpy.
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/milkyplay/PlayerSTD.cpp:544:20: runtime error: signed integer overflow: 256 * -8404992 cannot be represented in type 'int'
/home/soniex2/builds/milkytracker-git/src/milkytracker/src/milkyplay/PlayerSTD.cpp:544:13: runtime error: signed integer overflow: 2143289344 + 1727987712 cannot be represented in type 'int'
Looks like some tricky integer math for calculating envelopes, I think it's a logic error, don't know how it happened and how to fix it.
In my testing, I found that clicking the About button and triggering the animation results in different ubsan errors:
/home/nyanpasu64/code/MilkyTracker/src/fx/Filter.cpp:135:44: runtime error: signed integer overflow: 27 * -109107220 cannot be represented in type 'int'
/home/nyanpasu64/code/MilkyTracker/src/fx/Filter.cpp:131:31: runtime error: signed integer overflow: 27 * 81823760 cannot be represented in type 'int'
/home/nyanpasu64/code/MilkyTracker/src/fx/Filter.cpp:133:31: runtime error: signed integer overflow: 31 * 71335960 cannot be represented in type 'int'
This is due to tricky bitwise operations I don't understand and don't know how to fix.
ignore the xruns they're normal
commit 52e6a42d1f03c5fcb29b81f8cbdef8a9de9c4f55 (yeah this is old)