milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.68k stars 159 forks source link

Convert pattern to sample doesn't restore changed settings after finishing #261

Closed caseyjoy closed 2 years ago

caseyjoy commented 2 years ago

OS: Ubuntu 21.10 Milkytracker versions: latest Github source build (feature added in #243) Issue: When using the convert pattern to sample feature with Ctrl-shift-v or Ext. Paste->Capture pattern..., the HDRecorder settings are not stored and restored. Steps to reproduce:

or


This causes several problems:

caseyjoy commented 2 years ago

Working on a fix for this one.

It's looking like a better solution than storing and restoring the settings for sectionHDRecorder might be to not touch sectionHDRecorder at all, and use the underlying functionality and settings instead (since we probably want to use the main tracker volume/amp/mixer resolution instead of the sectionHDRecorder one the user was potentially using to render the song out earlier), potentially similar to how SectionHDRecorder::exportWAVAsSample does it.