feat: [raina] Add toggle for advanced drag n drop

milkytracker / MilkyTracker

An FT2 compatible music tracker

http://milkytracker.github.io/

Other

1.68k stars 159 forks source link

feat: [raina] Add toggle for advanced drag n drop #277

Closed ghost closed 1 year ago

ghost commented 2 years ago

Raina requested a toggle for the advanced drag and drop feature introduced in https://github.com/milkytracker/MilkyTracker/pull/211

@exelotl

coderofsalvation commented 1 year ago

I like this...lets hit the merge button if nobody else objects in upcoming week no?

ghost commented 1 year ago

I like this...lets hit the merge button if nobody else objects in upcoming week no?

Did you have a chance to review the code? Feel free to give me an approval.

coderofsalvation commented 1 year ago

I have reviewed it, tested it (works neato while holding shift!). Will be included in v1.04 milestone

ghost commented 1 year ago

I have reviewed it, tested it (works neato while holding shift!). Will be included in v1.04 milestone

I believe I can't merge it without approval. Did you approve it?

coderofsalvation commented 1 year ago

Oh I've actually merged to this release v1.04 candidate https://github.com/milkytracker/MilkyTracker/tree/rc/1.04 (which also has some other PR's in there). How about we close this PR after I release (this week)?

ghost commented 1 year ago

Oh I've actually merged to this release v1.04 candidate https://github.com/milkytracker/MilkyTracker/tree/rc/1.04 (which also has some other PR's in there). How about we close this PR after I release (this week)?

Ah, ok, wasn't aware of the pending release. All good then 👍

coderofsalvation commented 1 year ago

I'm also writing some docs for this advanced dragndrop. What I was able to test:

cloning the selection (sortof a stamp feature) when holding shift while dragging the selection

Let me know if I'm missing something.