milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.7k stars 160 forks source link

chore/copy-paste-sample-respect-relative-notenumber #290

Closed coderofsalvation closed 1 year ago

coderofsalvation commented 2 years ago

relnote

Problem: when copy/pasting a sample to a different sample-slot, the pitch (relative note+finetune) is completely off during playback (being reset to 0). Basically, everytime after pasting a sample, you need to dive into the instrument-editor and update the finetune & relative notenumber accordingly. This is very cumbersome when layering notes/drumkits etc.

Solution: the 'copy'-action in the sample-editor now remembers the finetune & relative notenumber (+28 in the screencapture), and the 'paste'-action will use those to update the relative notenumber of the destination-sampleslot (0 is changed to +28 in the screencapture).